TCA9548::disableChannel(uint8_t channel) is not working as expected

[pghj]

I think disableChannel was copy-pasted from enableChannel, but the condition !isEnabled(channel) was not inverted by mistake.

[RobTillaart]

Thank you for catching, definitely a (copy paste) BUG. Will fix asap, probably tomorrow.

[pghj]

Thanks for the quick response. It seems to me that the check can just be removed from both methods, because setChannelMask already tests the entire mask for changes.

[pghj]

Oops wrong button.

[RobTillaart]

It seems to me that the check can just be removed from both methods, because setChannelMask already tests the entire mask for changes.

Good idea, would simplify code a bit. Will create a develop branch asap to prepare for a 0.3.0 version.

[RobTillaart]

Propose code would also return false if the writing to the multiplexer failed.

bool TCA9548::enableChannel(uint8_t channel)
{
  if (channel >= _channels) return false;
  return setChannelMask(_mask | (0x01 << channel));
}

bool TCA9548::disableChannel(uint8_t channel)
{
  if (channel >= _channels) return false;
  return setChannelMask(_mask & ~(0x01 << channel));
}

[RobTillaart]

@pghj Develop branch created, build-CI is running. Some more edits were made.

[pghj]

Propose code

Looks good. Can you also make it return the result of setChannelMask when calling selectChannel?

[RobTillaart]

Will check after lunch

[RobTillaart]

Propose code

Looks good. Can you also make it return the result of setChannelMask when calling selectChannel?

done

[RobTillaart]

@pghj Do you have time to test the develop branch, otherwise I will merge it (as I see no issues for now).

[RobTillaart]

@pghj I merged develop and released 0.3.0 .

Again thanks for reporting the issue!