Adding a new non-required parameter to an endpoint shouldn't break contract

RobWin / assertj-swagger

A Swagger assertj test library which compares a contract-first Swagger YAML/JSON file with a code-first Swagger JSON

Apache License 2.0

171 stars 44 forks source link

Adding a new non-required parameter to an endpoint shouldn't break contract #11

Open madgnome opened 8 years ago

madgnome commented 8 years ago

satisfiesContract shouldn't fail if the implementation has an additional non-required parameter.

At the moment we get an error:

org.assertj.core.api.SoftAssertionError: 
The following assertion failed:
1) [Checking parameters of 'GET' operation of path '/mentions/search'] 
Actual and expected should have same size but actual size is:
 <3>
while expected is:
 <2>
Actual was:
<[io.swagger.models.parameters.QueryParameter@7569d537,
    io.swagger.models.parameters.QueryParameter@39224809,
    io.swagger.models.parameters.QueryParameter@4a3f02dd]>

RobWin commented 8 years ago

Hi,

thx for creating the issue. The project is maintained by the community. I don't fix any issues anymore, but I accept PRs and release new versions. If need this change, could you please create a PR?

Kind regards, Robert

benfowler commented 8 years ago

@madgnome no guarantee I'll be able to find the time to fix this -- but do you have an example of the request that caused the problem?

Zag24 commented 7 years ago

Hi. I have a fix for this, which I'd be glad to push on to a branch for you to code review and merge to master, if you'd like. Username: Zag24

RobWin commented 7 years ago

Hi Very nice. Just create a Pull Request and I review and merge it.

atsu85 commented 6 years ago

@RobWin, @Zag24, looks like this issue should have been closed manually after @RobWin cherry-picked @Zag24's commit that he refered to above

marcelstoer commented 5 years ago

looks like this issue should have been closed

👍