Implemented Required fields check

RobWin / assertj-swagger

A Swagger assertj test library which compares a contract-first Swagger YAML/JSON file with a code-first Swagger JSON

Apache License 2.0

171 stars 44 forks source link

Implemented Required fields check #14

Closed aabutaleb closed 7 years ago

aabutaleb commented 7 years ago

Adding check for required parameters
Adding unit tests for un-matching required parameters
Adding test case for unit tests
Since getRequired() is not exposed in the Model Interface, I had to cast to ModelImpl in order to get it. That only works for Models which have been asserted previously, but if there's an issue or possible improvement on that please let me know
Tested on real apps and working fine

coveralls commented 7 years ago

Coverage increased (+0.2%) to 87.299% when pulling d9cbf873cefb40f74f2937071ff1e0a76a1d9fec on whitbread-eos:feature/checking-required-fields into 05f6d61e771b9460bd294ca1161d9b0d24e8ffa2 on RobWin:master.

aabutaleb commented 7 years ago

One test is broken, wasn't flagged in my local build before, I'll fix

coveralls commented 7 years ago

Coverage increased (+0.5%) to 87.559% when pulling 91e7ed72bc13147ba516ff4afb96675ce6073404 on whitbread-eos:feature/checking-required-fields into 05f6d61e771b9460bd294ca1161d9b0d24e8ffa2 on RobWin:master.

RobWin commented 7 years ago

Thx