Fixed issue #24 by adding check on parameter types

RobWin / assertj-swagger

A Swagger assertj test library which compares a contract-first Swagger YAML/JSON file with a code-first Swagger JSON

Apache License 2.0

171 stars 44 forks source link

Fixed issue #24 by adding check on parameter types #25

Closed zacyang closed 6 years ago

zacyang commented 6 years ago

Hi, This PR is the fix for the issue on issue 24

I've added a test shouldPassTestForIdenticalParametersSetContainsParameterWithDifferentTypes to identify this issue described in the issue.

Please merge this PR if it ok. Also, it would be nice if could you release a new version as our project is pending on this fix to progress on the contract test part.

Thanks.

coveralls commented 6 years ago

Coverage decreased (-0.2%) to 87.52% when pulling bf3db51c8adae02bad36e1605f2a268dd1348e77 on zacyang:issue-24 into 179a1f78df2cc498d4ca257151e7536297953bc3 on RobWin:master.

RobWin commented 6 years ago

Thx