Refactored to separate documentation driven from consumer driven pattern

RobWin / assertj-swagger

A Swagger assertj test library which compares a contract-first Swagger YAML/JSON file with a code-first Swagger JSON

Apache License 2.0

171 stars 44 forks source link

Refactored to separate documentation driven from consumer driven pattern #7

Closed RobWin closed 8 years ago

RobWin commented 8 years ago

Added support for consumer driven contracts by way of a 'satisfiesContract' assertion.

coveralls commented 8 years ago

Coverage increased (+0.8%) to 86.224% when pulling e0e999bbe55ec13186c7300cb544c43e0e607585 on raceconditions:master into 6a6720868c4670d14a8bf4d0f4765242acfbf083 on RobWin:master.

RobWin commented 8 years ago

@raceconditions Thank you very much. Great PR. I would merge the PR, but could you please add some documentation (README) first?

RobWin commented 8 years ago

I would love to get your GitHub Star. :)

raceconditions commented 8 years ago

You've got it!

On Tue, Mar 22, 2016 at 9:08 AM, Robert Winkler notifications@github.com wrote:

I would love to get your GitHub Star. :)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/RobWin/assertj-swagger/pull/7#issuecomment-199805432

raceconditions commented 8 years ago

Rob,

No problem. I've updated the README and I'll be sending you a pull request shortly.

Travis

On Tue, Mar 22, 2016 at 9:06 AM, Robert Winkler notifications@github.com wrote:

@raceconditions https://github.com/raceconditions I would merge the result, but could you please add some documentation (README) first?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/RobWin/assertj-swagger/pull/7#issuecomment-199804609

coveralls commented 8 years ago

Coverage increased (+0.8%) to 86.224% when pulling 61e5a9d7d76ce855a7fda0b044f3c2b647300f84 on raceconditions:master into 6a6720868c4670d14a8bf4d0f4765242acfbf083 on RobWin:master.

coveralls commented 8 years ago

Coverage increased (+0.8%) to 86.224% when pulling e5af3fd545373198999f45cdc0f5fefd903f99f0 on raceconditions:master into 6a6720868c4670d14a8bf4d0f4765242acfbf083 on RobWin:master.

raceconditions commented 8 years ago

Rob - should be good to merge. I've updated the README and added a few more tests to the CDC side. I did not update the version number in the README as I'll let you determine how you want to version and release this.

RobWin commented 8 years ago

Done. Thx.

RobWin commented 8 years ago

v0.4.0 has been released

raceconditions commented 8 years ago

Thanks, Rob. I just noticed that the RELEASENOTES.adoc and README.adoc don't fully reflect the 0.4.0 release. I can help and update if you would like.

RobWin commented 8 years ago

Thx. Fixed