search

RobWin / jgitflow-gradle-plugin

A Gradle Plugin which adds tasks to support the Gitflow Workflow.
Apache License 2.0
48 stars 44 forks source link

Version handling on releaseFinish #20

Open fassmus opened 7 years ago

fassmus commented 7 years ago

When performing releaseFinish the -SNAPSHOT postfix is not striped from version property in gradle.properties before merging the release branch to master. The tag is named correctly but on master we still have the -SNAPSHOT postfix in gradle.properties. On develop the version increment is performed correctly. I also tried to remove the -SNAPSHOT postfix on the release branch before running releaseFinish. This resulted in following error:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':releaseFinish'.
> didn't replace anything
RobWin commented 7 years ago

Hi, would you like to contribute a PR?

fassmus commented 7 years ago

I will have a go at it next week.