Robbendebiene / Gesturefy

Navigate, operate, and browse faster with mouse gestures! A customizable Firefox mouse gesture add-on with a variety of different commands.
https://addons.mozilla.org/firefox/addon/gesturefy/
GNU General Public License v3.0
793 stars 74 forks source link

Open link in new tab not working on some links #130

Closed heizie78 closed 6 years ago

heizie78 commented 6 years ago

The gesture to open a link in a new (background) tab is not working on all links. e.g. on some Tumblr posts having multiple pictures, the gesture is not working when executed on the link to one of those pictures.

Robbendebiene commented 6 years ago

Can you please send me an example? This may be already fixed in the next update (https://github.com/Robbendebiene/Gesturefy/issues/90)

heizie78 commented 6 years ago

Maybe the same issue. Try to open picture 2 and 3 on that blog with the gesture. http://architectureblog.tumblr.com/ With right-click --> open in new tab it works fine.

Robbendebiene commented 6 years ago

Sorry, everything is working fine for me.

heizie78 commented 6 years ago

Please see screenshot. My gesture to open link in background is just UP. What it is actually doing is RIGHT-UP or LEFT-UP when I execute the gesture on the image link. It looks like it is starting the gesture on the wrong position. For other links it is working fine. I'm on Win10 with FFv57 and I just completely reset my FF profile. gesture

Robbendebiene commented 6 years ago

Strange. Which version of gesturefy are you using? Also which mouse button do you use to draw your gestures? Does it happen all the time when you start a gesture on that link/image?

heizie78 commented 6 years ago

I'm using version 1.1.15. As button I use the right-mouse button. Yes, it happens all the time. I was wondering if it may have to do with the fact that I'm using two high-res screens?! I have noticed that when I place the FF window on the left screen the situation above occurs. When I place FF on the right screen the exact opposite gesture error occurs. It is doing gesture RIGHT-UP all the time. Also the green gesture trail is coming from the other side. I switched off one screen, but still happens. Maybe it has only to do with high-res?

heizie78 commented 6 years ago

Just switched to resolution 1366x768 and it is working fine!

heizie78 commented 6 years ago

Noticed the same issue with forward/backward (right/left) gestures on some sites. e.g. here http://www.swissquote.ch/index/index_quote_e.html seems to be an issue with the screen resolution and/or window size.

Robbendebiene commented 6 years ago

It's not related to the gesture you use.

seems to be an issue with the screen resolution and/or window size.

Which window size leads to this problem? Because I'm still unable to reproduce it.

haugs commented 6 years ago

I have the problem on 1920x1080. It occurs on my laptop screen, but also when when using an extrenal monitor. What I can confirm is that the behaviour worsenes when extending the screen to a secondary monitoring. When I run FF on my primary screen the gestures are working fine in the top left corner and its getting worse when using it further to the right or bottom. When I run FF on the secondary screen the problem is already strongly present in the top left corner.

heizie78 commented 6 years ago

I can confirm that. I'm using two high-res screens with 3200x1800 and 3840x2160. Only dramatically reducing the resolution on both screens or using only one screen with low-res like 1366x768 fixes the issue.

Robbendebiene commented 6 years ago

Can you please open the console (F11), execute the following line of code: window.devicePixelRatio and tell me the output number. Also ensure that the website where you run this code is not zoomed in or out.

heizie78 commented 6 years ago

The output is 2

Robbendebiene commented 6 years ago

@heizie78 Can you please try if it is fixed in this version.

  1. donwload and unzip
  2. disable the existing gesturefy addon
  3. go to about:debugging and select "load temporary addon"
  4. select the manifest.json from the unzipped zip
heizie78 commented 6 years ago

Looks fixed! :-) At least until now I did not experience any issues.

Robbendebiene commented 6 years ago

I will try to upload the patch this week.

Robbendebiene commented 6 years ago

Version 1.1.17 is available on Mozilla. Bug fix reference: https://github.com/Robbendebiene/Gesturefy/commit/331bdaff9a374f2b014fb0cb0fbbaa5e7c038c56