search

Robbepop / apint

Arbitrary precision integers library.
Other
27 stars 4 forks source link

added unit tests, methods, and more for finishing multiplication implementation #21

Closed AaronKutch closed 6 years ago

AaronKutch commented 6 years ago

added some methods to Digit and DoubleDigit for convenience, added wrapping_inc and fixed negate, replaced the unimplemented! section in the checked_mul_assign function, and added a rigorous unit test.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+2.0%) to 70.409% when pulling 7d2fb70c13dc15d27f98c1d132abc2c07d8ee3c9 on AaronKutch:iss18 into 24662099b8494b42c2f0b670724b93ce537fbd2d on Robbepop:master.

codecov-io commented 6 years ago

Codecov Report

Merging #21 into master will increase coverage by 1.97%. The diff coverage is 98.59%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #21      +/-   ##
=========================================
+ Coverage   68.32%   70.3%   +1.97%     
=========================================
  Files          23      23              
  Lines        4089    4358     +269     
=========================================
+ Hits         2794    3064     +270     
+ Misses       1295    1294       -1
Impacted Files Coverage Δ
src/digit.rs 89.26% <100%> (+2.88%) :arrow_up:
src/apint/arithmetic.rs 81.41% <98.41%> (+11.71%) :arrow_up:
src/ll.rs 0% <0%> (-50%) :arrow_down:
src/apint/casting.rs 64.22% <0%> (+0.4%) :arrow_up:
src/apint/bitwise.rs 72.53% <0%> (+2.11%) :arrow_up:
src/apint/utils.rs 79.23% <0%> (+4.91%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2466209...7d2fb70. Read the comment docs.

Robbepop commented 6 years ago

Wow this is amazing work!!

I have looked over the code and comments and it looks really good to me! :)

Robbepop commented 6 years ago

Do you want me to merge it asap?

AaronKutch commented 6 years ago

merge it. Next pull request I plan on looking at some of the other arithmetic functions and see if benchmarks improve when I make some changes. After that, I will pull request my division function, and then after that is the name changing. I would also try SIMD, but unfortunately I need to get back to my project. Maybe some time in the future I can come back and do SIMD and Karatsuba.

Robbepop commented 6 years ago

Thank you for all the glorious work - it is amazing! :tada:

I will merge this and release a 0.3 version of the apint crate.