AaronKutch commented 6 years ago

This changes no functionality, and only converts the tab indentation to spaces and ... to ..=.

coveralls commented 6 years ago

Coverage remained the same at 70.409% when pulling 291ce3292956cff7451cdc25d018034537a927ce on AaronKutch:indentchange into 32ca6304a32808fd34ed440022d54132bc67180c on Robbepop:master.

AaronKutch commented 6 years ago

Also, there is one more name change I would like to make involving from_str_radix and the to string things before 0.3 is released. I will open an issue on it

codecov-io commented 6 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is 69.72%.

@@          Coverage Diff           @@
##           master     #24   +/-   ##
======================================
  Coverage    70.3%   70.3%           
======================================
  Files          23      23           
  Lines        4358    4358           
======================================
  Hits         3064    3064           
  Misses       1294    1294

Impacted Files	Coverage Δ
src/ll.rs	`0% <0%> (ø)`	:arrow_up:
src/int.rs	`0% <0%> (ø)`	:arrow_up:
src/uint.rs	`0% <0%> (ø)`	:arrow_up:
src/checks.rs	`100% <100%> (ø)`	:arrow_up:
src/bitpos.rs	`100% <100%> (ø)`	:arrow_up:
src/apint/shift.rs	`100% <100%> (ø)`	:arrow_up:
src/storage.rs	`100% <100%> (ø)`	:arrow_up:
src/apint/relational.rs	`29% <29%> (ø)`	:arrow_up:
src/errors.rs	`31.97% <31.25%> (ø)`	:arrow_up:
src/apint/rand_impl.rs	`91.17% <50%> (ø)`	:arrow_up:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32ca630...291ce32. Read the comment docs.

Robbepop commented 6 years ago

Thanks again for all the work! :)

As I said already I would be really pleased if we could try to separate pull requests into semantic pieces. For example a single pull request for the indentation fix using whitespace and another pull request for the conversion from ... to ..=.

Since both are merged I cannot see where the conversion was done in the code and code review is very hard then.

AaronKutch commented 6 years ago

Sorry if I am causing you trouble because I am used to working with minimal version control and doing lots of breaking stuff, but can you see the separate commits, one of which is just for ..=? I will try to be more careful next time

Robbepop commented 6 years ago

I am so sorry I didn't see the separate commits. That's helping a lot for code review! :)

Keep up the good work!

Robbepop / apint

Change indentation and convert `...` to `..=` #24

Codecov Report