Use `slice::iter` instead of `into_iter` to avoid future breakage

Robbepop / apint

Arbitrary precision integers library.

Other

26 stars 4 forks source link

Use `slice::iter` instead of `into_iter` to avoid future breakage #52

Closed LukasKalbertodt closed 5 years ago

LukasKalbertodt commented 5 years ago

an_array.into_iter() currently just works because of the autoref feature, which then calls <[T] as IntoIterator>::into_iter. But in the future, arrays will implement IntoIterator, too. In order to avoid problems in the future, the call is replaced by iter() which is shorter and more explicit.

A crater run showed that your crate is affected by a potential future change. See https://github.com/rust-lang/rust/pull/65819 for more information.

coveralls commented 5 years ago

Coverage decreased (-0.05%) to 75.869% when pulling 9b48841e568424ac0f65b77c5d49d94161a51ac1 on LukasKalbertodt:master into ec30c2047f0e3cfdcc5dbd7b59f3b370a2aa8901 on Robbepop:master.

LukasKalbertodt commented 5 years ago

I'm not sure how the coverage can decrease from this change :confused:

Robbepop commented 5 years ago

I'm not sure how the coverage can decrease from this change 😕

Well it is just -0.05% so I personally don't care. Thank you for the PR!