Remove libm dependency and fix compilation error

Robbepop / apint

Arbitrary precision integers library.

Other

27 stars 4 forks source link

Remove libm dependency and fix compilation error #53

Closed AaronKutch closed 4 years ago

AaronKutch commented 4 years ago

The compilation error only happened if compiled with serde_support

AaronKutch commented 4 years ago

Should the tests work in no_std? If so, I can add a cfg to the one test with log2.

coveralls commented 4 years ago

Coverage decreased (-0.6%) to 75.237% when pulling f6919f28980fd78b2bd4c65f379df46309dd4673 on AaronKutch:remove_libm into b1612552d08e29b42fb1f3ef64966f9918f040e6 on Robbepop:master.

coveralls commented 4 years ago

Coverage decreased (-0.6%) to 75.237% when pulling f6919f28980fd78b2bd4c65f379df46309dd4673 on AaronKutch:remove_libm into b1612552d08e29b42fb1f3ef64966f9918f040e6 on Robbepop:master.

AaronKutch commented 4 years ago

I think we should always run tests with the default set of features and only worry about the build working in other cases.

AaronKutch commented 4 years ago

Are you waiting to merge it? I am confused about the purpose of just approving a PR.

Robbepop commented 4 years ago

Are you waiting to merge it? I am confused about the purpose of just approving a PR.

I was on my phone, not laptop. Also I am curious why CI fails for this PR. Let me check.

Robbepop commented 4 years ago

Should the tests work in no_std? If so, I can add a cfg to the one test with log2.

Tests don't have to work for no_std but build does.

AaronKutch commented 4 years ago

Thanks for clearing that up.

Robbepop commented 4 years ago

I just restarted the Travis CI job.

AaronKutch commented 4 years ago

Its still timing out for some reason

Robbepop commented 4 years ago

Dont know why but looks odd to me.