Robbepop / apint

Arbitrary precision integers library.
Other
27 stars 4 forks source link

Add initial GitHub actions CI #57

Closed Robbepop closed 3 years ago

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.4%) to 80.461% when pulling 0571bf7047afd14dbae701395dd0ff310b5a0138 on add-GitHub-actions-CI into 130949d37601a809d8d463430a94cbb17251a7a6 on master.

codecov-io commented 4 years ago

Codecov Report

Merging #57 into master will decrease coverage by 0.08%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   80.47%   80.38%   -0.09%     
==========================================
  Files          23       22       -1     
  Lines        5229     5145      -84     
==========================================
- Hits         4208     4136      -72     
+ Misses       1021     1009      -12     
Impacted Files Coverage Δ
src/apint/serde_impl.rs 76.29% <0.00%> (-1.57%) :arrow_down:
src/radix.rs 88.57% <0.00%> (-0.32%) :arrow_down:
src/apint/rand_impl.rs 92.20% <0.00%> (-0.30%) :arrow_down:
src/bitwidth.rs 88.88% <0.00%> (-0.18%) :arrow_down:
src/apint/utils.rs 79.25% <0.00%> (-0.11%) :arrow_down:
src/apint/casting.rs 76.29% <0.00%> (-0.11%) :arrow_down:
src/apint/arithmetic.rs 93.33% <0.00%> (-0.10%) :arrow_down:
src/apint/constructors.rs 97.44% <0.00%> (-0.08%) :arrow_down:
src/digit.rs 94.20% <0.00%> (-0.05%) :arrow_down:
src/apint/to_primitive.rs 96.38% <0.00%> (-0.01%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 130949d...0571bf7. Read the comment docs.

AaronKutch commented 4 years ago

There are some CI related commits currently on the end of PR #56. For the miri and debug tests, we need to add a flag to disable most of the fuzz testing. We don't want to get rid of the fuzz testing completely like the current situation is in #56. I want the fuzz testing to run for a few iterations (I'll figure out the practical numbers in a separate PR for issue #47). For now, I would add a flag such as "expensive_tests" that enables the megafuzz module in arithmetic.rs. I think I should just remove the CI commits from #56 and handle all that here.

Does GitHub actions straight up replace the Appveryor and Travis stuff? I did a small amount of searching, but the way these things interact is still very fuzzy in my mind.

Robbepop commented 4 years ago

There are some CI related commits currently on the end of PR #56. For the miri and debug tests, we need to add a flag to disable most of the fuzz testing. We don't want to get rid of the fuzz testing completely like the current situation is in #56. I want the fuzz testing to run for a few iterations (I'll figure out the practical numbers in a separate PR for issue #47). For now, I would add a flag such as "expensive_tests" that enables the megafuzz module in arithmetic.rs. I think I should just remove the CI commits from #56 and handle all that here.

Does GitHub actions straight up replace the Appveryor and Travis stuff? I did a small amount of searching, but the way these things interact is still very fuzzy in my mind.

Having miri testing would be a big win to uncover undefined behaviour bugs. I have not yet figured out how we can get coverage reports to work but I hope I can get it working soon since it is very important imo. A crate feature to toggle fuzz testing is very important even without CI.

As soon as GitHub actions works we can get rid of Appveyor and Travis CI.

Robbepop commented 3 years ago

This PR is superseeded by https://github.com/Robbepop/apint/pull/64. Closed.