search

Robbepop / modular-bitfield

Macro to generate bitfields for structs that allow for modular use of enums.
Apache License 2.0
159 stars 41 forks source link

Add .with() syntax #20

Closed lkolbly closed 3 years ago

lkolbly commented 4 years ago

.with() and .with_checked() allow creating bitfields without using mutable variable.

Fixes #17

lkolbly commented 3 years ago

Thank you for the crate!

I can rebase this evening, if you prefer. Although actually, it looks like "Allow edits by maintainers" is checked, so in principle you should be able to directly rebase my master branch? I dunno, I've never done that. Whatever works best for you.

Robbepop commented 3 years ago

Thank you for the crate!

I can rebase this evening, if you prefer. Although actually, it looks like "Allow edits by maintainers" is checked, so in principle you should be able to directly rebase my master branch? I dunno, I've never done that. Whatever works best for you.

I am totally fine with you rebasing this evening! Will review and eventually merge afterwards. :)

lkolbly commented 3 years ago

Alright, rebased and the tests pass on my machine.

lkolbly commented 3 years ago

I'm not sure what's happening with the miri check, it looks like this is the failure:

error: unknown `-Z` flag specified: miri-disable-isolation
Error: The process '/usr/share/rust/.cargo/bin/cargo' failed with exit code 101
Robbepop commented 3 years ago

I'm not sure what's happening with the miri check, it looks like this is the failure:

error: unknown `-Z` flag specified: miri-disable-isolation
Error: The process '/usr/share/rust/.cargo/bin/cargo' failed with exit code 101

Everything is alright. miri simply does not work for this crate. The CI check is not required for PRs to merge.