Robbepop / modular-bitfield

Macro to generate bitfields for structs that allow for modular use of enums.
Apache License 2.0
159 stars 41 forks source link

Change the getter names to be the field name #24

Closed Qyriad closed 3 years ago

Qyriad commented 3 years ago

Supersedes #15. Closes #14. As in #15, tuple structs have their getters as get_n(), where n is the index of the field, but I added the documentation for tuple struct behavior onto the #[bitfield] macro as requested in https://github.com/Robbepop/modular-bitfield/pull/15#issuecomment-591629400. If this isn't sufficient I can edit further.

I also rebased onto master.

Robbepop commented 3 years ago

I am currently a bit short on time until 15th of oct. Will do a proper review. Please ping me here if I forget during the time! Thanks for your contributions!

Qyriad commented 3 years ago

No worries! Please take your time! I understand things can be busy and you might not always have the time and/or energy to get around to these things.