search

RobbieTheWagner / ember-flatpickr

An Ember addon that wraps the Flatpickr date picker
https://RobbieTheWagner.github.io/ember-flatpickr/
MIT License
109 stars 54 forks source link

Require ember 4.8+ and test-helpers 3.x #2036

Closed AmauryD closed 5 months ago

AmauryD commented 5 months ago

Resolves #1977

RobbieTheWagner commented 5 months ago

@AmauryD it looks like we probably need to run ember-cli-update as well and drop support for Ember < 4.8 to make this work.

AmauryD commented 5 months ago

@RobbieTheWagner Job's done ! I also updated the peerDeps string to only allow ember-source > 4.8 https://github.com/RobbieTheWagner/ember-flatpickr/pull/2036/commits/cf95301bf55822d0d4eddbe240ce915a8df4eb71 (don't know if you consider that breaking ?)

RobbieTheWagner commented 5 months ago

@AmauryD looks like there are some conflicts. Once those are resolved, we can merge.