RobbieTheWagner / ember-shepherd

An Ember addon for the site tour library Shepherd
https://robbiethewagner.github.io/ember-shepherd/
MIT License
157 stars 45 forks source link

Add test helpers #266

Open BrianSipple opened 6 years ago

BrianSipple commented 6 years ago

Ongoing idea list:

grapho commented 4 years ago

I support this idea, though perhaps exposing Shepherd's modalContainer would allow tours to render inside of the actual app and therefore could be tested in acceptance tests and possibly allow for visual regression tests (Percy)

RobbieTheWagner commented 4 years ago

@grapho I responded to this in the other issue, but responding here as well. All Shepherd options can be used in ember-shepherd, without the need to expose extra things. You would have to pass these options as part of your tour/steps config, like the other options.

Also, Ember's test helpers take a parent element, so you are not limited to the Ember testing container, and you can still write tests here.