Rober-Igtm / Clash_of_Souls_in_Faust

Project to analyze the text of Goethe's Faust and the orientation of Faust's acts and wishes to each of his two souls.
3 stars 1 forks source link

Presentation #14

Open djbpitt opened 4 years ago

djbpitt commented 4 years ago

Terrific presentation today, and your site looks terrific. Here are a few thoughts, mostly about a bit of fine-tuning, since most of the content is already present, and the foundation is solid:

  1. If you haven’t done so already, be sure to validate all of your HTML at https://validator.w3.org/ and all of your CSS at https://jigsaw.w3.org/css-validator/.
  2. It’s tricky to make uniform graphs when the volume of data can vary as much as it does from chapter to chapter. You know your data better than I do, so I’m not going to offer a specific suggestion, except that you might to review that page with eye toward both how each graph looks on its own and how they work together to make up a coherent page. Compromises may be required, in which case the best you might be able to do is to make those compromises deliberately and consciously, taking the different perspectives into consideration. Why not make all of the X axes the same length, since you’re dealing with percentages? I wish I had something specific to suggest with the Y axes, which are challenging because of the great variation in scope and scale, but you might want to brainstorm this within your team (let the instructors know if you’d like us to participate).
  3. I find the teal (especially) and the yellow text hard to read against the white background. The all-cap underlined titles might look better if you used less typewriter-oriented means of emphasis (use a different font, or font size, or bolding, or something instead), and it’s cut off on the edges in the graph for Chapter 7. The labels on the X axis end prematurely in the graph for Chapter 19. Chapter 23 has a bar chart, rather than a line graph.
  4. Your graphs are a great fit for your research question, and I like the cumulative line strategy. After the presentation someone mentioned an alternative where the accumulation builds to a 100, and that’s what you’d want if you were showing how the 100% total was constructed over time. But because you also want to compare the total raw numbers over time, since you’re contrasting the representation of the two souls in each chapter, the approach you’ve taken may be a better cumulative strategy for your particular data set and research question.
  5. We already chatted a bit, during the presentation, about the dotted look of some of the graphs, and I’d encourage you to try a polyline. One coding challenge with a polyline is that it wants all of the coordinates at once, while you may be plotting incrementally. A common way to deal with that sort of situation is to process all of the chapters in a mode inside a variable declaration, so that you’re saving all of the numbers up front. You can then refer to the variable to create the polyline, and you’ll have all of the numbers available at the same time. I used to draw line graphs segment by segment, recalculating the preceding point each time I added a new one, but once I learned about polylines, I never looked back at that earlier, fragmented approach.

Great job!