search

Robert-W / grunt-ftp-push

Deploy files to an FTP server as part of your Grunt workflow.
MIT License
39 stars 14 forks source link

"dest" option for files #13

Closed ivoberg closed 9 years ago

ivoberg commented 10 years ago

I added a feature to have "dest" option in files so it's possible to define a destination path for the files after the path defined in "options". Is it possible to contribute to the project, as I would need this to be destributed through npm so I odnt have to send the file to my colleagues, but it would already there on npm install =)

Waiting reply, Thank you!

Robert-W commented 10 years ago

Hi @ivoberg, If you would like to submit a pull request I can try to get this added in, sounds like it could be a useful feature for some cases. I have recently rewritten the plugin to be more testable (plan on adding unit tests very soon) so depending on which version of the plugin you added this feature it may require some minor changes to tie it into the new design.

ivoberg commented 10 years ago

pull request sent ;) thx for the reply... however I don't know if I should just wait for the new code. Well, hope you find this new option viable

Robert-W commented 10 years ago

@ivoberg I would keep using yours for now, is going to take me about a week to get to this integrated and release a new version as I have school starting soon and a lot going on at work right now. Thanks again for the input, its much appreciated.

Robert-W commented 10 years ago

Opening to serve as a reminder for myself that I need to accept and integrate this pull request.

ivoberg commented 10 years ago

there was another update I made, something I forgot, should I pull request or leave it as is.. think this is something you would better do in a less "hack" form

Robert-W commented 10 years ago

Can you update a previous pull request? (I have never tried so I am not sure if you can or not) If you can update it I can take a look at the changes and see what it will take to make it a less hacky solution. Or if you wanna post them here as a snippet I can take a look that way as well.

Robert-W commented 9 years ago

@ivoberg This has been merged in, works great, I added some extra code in case the user provides a directory in dest that has not been created and is not created in the regular workflow of the uploads, this way it will still work without throwing a Can't open that file error. I also cleaned up the code a little as all those ternary expressions were becoming a bit of an eyesore. It is committed but not published, will be published by the end of this week after some more testing. Thanks.