search

Robert-W / grunt-ftp-push

Deploy files to an FTP server as part of your Grunt workflow.
MIT License
39 stars 14 forks source link

Allow / for options.dest #26

Closed rarila closed 9 years ago

rarila commented 9 years ago

Setting / as options.dest does not work as the destinations aren't allowed to start with /.

This is needed for the following constructs (probably also for writing directly to the rootpath) as options.dest is checked for being not empty as requirement.

    options: {
        ...
        dest: '/'
    },
    target1: {
        files: [{
            ...
            dest: 'foo/bar'
        }]
    },
    target2: {
        files: [{
            ...
            dest: 'bar/foo'
        }]
    }
Robert-W commented 9 years ago

Ill try to check this out tonight or tomorrow, this is another one that should have been resolved by another pr a while back (don't quote me on that, I will go back and double check to see if that is the case but I can't remember without digging into it). If this is still an issue and this fixes it I have no problem merging this in.

rarila commented 9 years ago

Great!

Robert-W commented 9 years ago

Looks like this should be fixed in branch 0.4.0 as it is now using nodes path.normalize which is better then what I was using before, I will close this pull request when 0.4.0 is released and working. In the meantime, keep using your version and then you can try upgrading to 0.4.0 when its out. Im going to try to release it this weekend if I have time in between me moving. If not released this weekend for sure will be released by next Tuesday at the latest.

rarila commented 9 years ago

No need to hurry, I'm on vacation :sunglasses: :palm_tree: :sunny:

Have a nice moving! :truck:

Robert-W commented 9 years ago

Hey man, Hope you had a good vacation, 0.4.0 was released earlier tonight which should include a fix similar to what you provided. If you notice this is still not working properly, please open a pull request or submit a new issue. master branch is essentially 0.4.0.

rarila commented 9 years ago

Thanks, gonna test as soon as I'm back home