search

Robert-W / grunt-ftp-push

Deploy files to an FTP server as part of your Grunt workflow.
MIT License
39 stars 14 forks source link

Hide credentials if necessary #41

Closed ghost closed 8 years ago

ghost commented 8 years ago

For automatic ci systems like travis, it is often desired to hide credentials from public console log. For this, a proof of concept is showed here which hides log.

At present, only username is hid from console log and there is no mention of it into readme.md. But I think for proof of concept, it is ok...

ghost commented 8 years ago

In https://github.com/MythicAngel/grunt-ftp-push/commit/673efcf01dd865bcc0275a0adea1e5fd9e611a0b commit's log message I have mistakenly referred issue 3 (which is actually no of opened issue) instead of 40. Sorry for that, can't amend this from web.

Robert-W commented 8 years ago

Looks good, will merge and document tonight.

Robert-W commented 8 years ago

Thanks for the proof of concept, I took what you posted and modified it a tad. It will now log '<username>' if auth fails or succeeds when the hideCredentials option is set to true, default value is false so make sure to add that in. I also updated the README with description and release notes and published to npm as version 0.4.4. Thanks

ghost commented 8 years ago

Robert, I'm just curious why you are not in 1.X.X version yet? Your repository is perfectly working in production environment and I seriously believe that it should be 1.0.0+

Thanks for the new version. It works...

Robert-W commented 8 years ago

Good question. I was going to go 1.0 a while ago but then I decided to rewrite the whole plugin and clean it up and kind of forgot about it. I have one issue lingering with some people on Ubuntu systems, but I think I will update to 1.0.0 after that issue is resolved. Glad everything is working good !!