search

RobertBColton / DockFX

A fully featured docking library for the JavaFX platform.
Mozilla Public License 2.0
278 stars 105 forks source link

Error dragging DockNode from one DockPane to another #24

Open jplwill opened 8 years ago

jplwill commented 8 years ago

I found an error if I try dragging a DockNode from one DockPane to another. The error scenario is like this:

  1. Create two DockPanes side by side, A and B.
  2. Create DockNode A1, and dock it in A.
  3. Drag A1 to B and dock it. (This works, once I fixed a bug involving B not yet having a "root" SplitPane.)
  4. Create DockNode A2, and dock it in A.
  5. Drag A2 to B and try to dock it. It doesn't seem to matter where.
  6. A1 is docked where A2 was supposed to go; the space where A1 was supposed to go remains empty; and A2 remains floating.
  7. I'm seeing two DOCKED_RELEASED events, one for A1, then one for A2. It doesn't seem that A1 should get one.

Has anyone fixed this in one of the various forks?

SamCooper commented 8 years ago

Can you try it in my fork as I've been doing a lot of work in this area.

jplwill commented 8 years ago

I'll give that a try.

jplwill commented 8 years ago

Sam, I see the same problem in your fork, after downloading a .zip of your master branch.

SamCooper commented 8 years ago

Hmm....

It would hopefully be fixed by this if I get a chance to work on it:

https://github.com/ClearControl/DockFX/issues/17

I did have it working but there was a problem with missing title bars which prompted the refactoring

jplwill commented 8 years ago

What I'm most curious about is how to fix it in the vanilla RobertBColton version, which is almost exactly what I need, modulo a few bug fixes and a couple of enhancements I'm working on that don't seem to be of general interest. For my current purposes, I don't need or want many of the enhancements I see other folks working on.