RobertBeckebans / RBDOOM-3-BFG

Doom 3 BFG Edition source port with updated DX12 / Vulkan renderer and modern game engine features
https://www.moddb.com/mods/rbdoom-3-bfg
GNU General Public License v3.0
1.38k stars 247 forks source link

Fix premature cinematic audio cutoff for .bik files when using ffmpeg decoder #823

Closed SRSaunders closed 2 months ago

SRSaunders commented 6 months ago

Fixes #821:

  1. Cinematic audio no longer cuts off 0.5 sec before the end of .bik files when using the ffmpeg decoder. Not an issue for the bundled Bink decoder.
  2. Also implements proper a/v resync for the ffmpeg decoder (all file types) if there are real-time pauses or skip-ahead requests during playback.

Thanks to @MadDeCoDer for the motivation to use queues vs. a ring buffer for a/v sync.

RobertBeckebans commented 2 months ago

I haven't tested this but it looks good.

SRSaunders commented 2 months ago

Thanks for merging.