Maintenance: update vendored minizip code to the version distributed with zlib v1.3

RobertBeckebans / RBDOOM-3-BFG

Doom 3 BFG Edition source port with updated DX12 / Vulkan renderer and modern game engine features

https://www.moddb.com/mods/rbdoom-3-bfg

GNU General Public License v3.0

1.38k stars 247 forks source link

Maintenance: update vendored minizip code to the version distributed with zlib v1.3 #829

Closed jayaddison closed 3 months ago

jayaddison commented 6 months ago

Opening this as a draft pull request initially; I haven't yet compiled or tested these changes.

I've tried to be careful to maintain the following differences from the baseline distribution of minizip:

Comments to explain where the code has been sourced from.
Differences to the #include paths for zlib.h.
The unzReOpen function added by iD.

jayaddison commented 6 months ago

cc @DanielGibson since I think you helped with documenting some of the origins of this code, and also in case you want to schlep these changes to any other codebases (hopefully not too many merge conflicts).

jayaddison commented 3 months ago

I haven't found time to build and test this successfully; getting shaders to build in particular seemed to be a challenge. I'm going to close this, but please feel free to re-use the code if it's useful.

Note also that zlib 1.3.1 has been released recently, and includes a couple of security fixes.