RobertBeckebans / RBDOOM-3-BFG

Doom 3 BFG Edition source port with updated DX12 / Vulkan renderer and modern game engine features
https://www.moddb.com/mods/rbdoom-3-bfg
GNU General Public License v3.0
1.37k stars 244 forks source link

clang compile failure in idGuiModel::EmitImGui() #842

Closed SRSaunders closed 4 months ago

SRSaunders commented 4 months ago

Missing static_cast<short> in certain initializer list elements. Will fix in coming pull request.

/Users/steve/XcodeProjects/RBDOOM-3-BFG/neo/renderer/GuiModel.cpp:398:5: error: type 'float' cannot be narrowed to 'short' in initializer list [-Wc++11-narrowing]
                                io.DisplaySize.y - static_cast<short>( pcmd->ClipRect.w ),
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/steve/XcodeProjects/RBDOOM-3-BFG/neo/renderer/GuiModel.cpp:398:5: note: insert an explicit cast to silence this issue
                                io.DisplaySize.y - static_cast<short>( pcmd->ClipRect.w ),
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                static_cast<short>(                                      )
/Users/steve/XcodeProjects/RBDOOM-3-BFG/neo/renderer/GuiModel.cpp:400:5: error: type 'float' cannot be narrowed to 'short' in initializer list [-Wc++11-narrowing]
                                io.DisplaySize.y - static_cast<short>( pcmd->ClipRect.y ),
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/steve/XcodeProjects/RBDOOM-3-BFG/neo/renderer/GuiModel.cpp:400:5: note: insert an explicit cast to silence this issue
                                io.DisplaySize.y - static_cast<short>( pcmd->ClipRect.y ),
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                static_cast<short>(                                      )
2 errors generated.