search

RobertBeckebans / RBDOOM-3-BFG

Doom 3 BFG Edition source port with updated DX12 / Vulkan renderer and modern game engine features
https://www.moddb.com/mods/rbdoom-3-bfg
GNU General Public License v3.0
1.37k stars 244 forks source link

Save changes to Render Mode and CRT Filter settings across launches #859

Closed SRSaunders closed 2 months ago

SRSaunders commented 2 months ago

Fixes #858

Also properly fixes issue where game is not waiting long enough on exit before shutting down Vertex Cache. Current code using GL_BlockingSwapBuffers() is not correct for the nvrhi implementation, especially when using triple buffering. The correct solution is to wait on device idle. This also eliminates the need for an #ifdef based on build config options. This same fix is also included in #849, but I am not sure if that PR will be merged, so I am duplicating the fix here to make sure.

RobertBeckebans commented 2 months ago

Thank you I completely overlooked this.