search

RobertBeckebans / RBDOOM-3-BFG

Doom 3 BFG Edition source port with updated DX12 / Vulkan renderer and modern game engine features
https://www.moddb.com/mods/rbdoom-3-bfg
GNU General Public License v3.0
1.37k stars 244 forks source link

Fix warning idClipModel::FreeTraceModel: tried to free uncached trace model #861

Closed SRSaunders closed 2 months ago

SRSaunders commented 2 months ago

Fixes a few small issues:

  1. Fixes #860. The solution is to make sure the traceModelCache entry for defaultClipModel is properly allocated and refcounted following restore from a save file. Previously the refcount for the default trace model was not augmented following a restore and this would lead to warning messages on map shutdown/quit.
  2. Also fixes an issue with the DeepGBufferRadiosity_blur.ps.hlsl shader where FAR_PLANE_Z was not declared static and the initializer was ignored. Warning messages from DXC are not shown to the user and therefore the issue was missed. (note: DXC warning messages are now shown with ShaderMake)
  3. Updates macOS bundle version string to 1.6.0
  4. Fix Optick type mismatches for non-windows 64-bit platforms (linux and macOS).
  5. Improve Optick error reporting to support output to debugger window and console stderr on all platforms.

Note this aligns all Optick changes with those submitted to the optick project at https://github.com/bombomby/optick/pull/196