RobertBeckebans / RBDOOM-3-BFG

Doom 3 BFG Edition source port with updated DX12 / Vulkan renderer and modern game engine features
https://www.moddb.com/mods/rbdoom-3-bfg
GNU General Public License v3.0
1.37k stars 244 forks source link

Issue with `idSoundVoice_XAudio2::Create` and custom voice files #864

Open WSSDude opened 2 months ago

WSSDude commented 2 months ago

We made a czech dubbing long time ago, around RBDOOM3 1.1.0 version. Dubbing used to work fine with both, this and original engine. Now it seems that, somewhere along the way, something broke in RBDOOM3.

Original engine has 0 trouble loading the czech dubbing we made. RBDOOM3-BFG-1.2.0 also works. Problems start after the said RBDOOM version.

Any release I test our dubbing with after 1.2.0 dies inside idSoundVoice_XAudio2::Create in file neo\sound\XAudio2\XA2_SoundVoice.cpp when it tries to call CreateSourceVoice. Im unable to find out what went wrong and Im unsure what exactly is going on.

Here is some sample .idwav and source .wav and .amp files. This is intro for base game, so you should be able to replicate the issue by clicking on new game with these. sample.zip

We have the generated folder in custom .resources file, as mentioned, it gets loaded normally in old RBDOOM3 build and original build game ships with, so something weird must be messed up :suspect:

If needed, I can provide you with more samples. Didnt want you to have to install whole dubbing to reproduce an issue.

WSSDude commented 2 months ago

I should have mentioned this I suppose, but the .idwav file I shared was generated with latest RBDOOM3 release available. All of them were regenerated before the report. Was unable to launch latest master when I compiled it myself for whatever reason, even though I had all resources in right places :suspect: So did not test with it.

I did it as a debugging step, to make sure something unexepcted isnt in a file by a chance. Originals made with RBDOOM3 1.1.0 do not work also.

Both generated files work just fine as mentioned on original engine and up to RBDOOM3 1.2.0 release, after which I'm unable to get voice playback with the czech dubbing.

In case it matters, I have Windows 11 Pro 23H2 64-bit. We had few reports about this from other users as well, unsure what their systems were.