Refactor tools/eMMC/functions.sh

RobertCNelson / boot-scripts

Just a bunch of useful scripts placed under /opt/scripts/

124 stars 131 forks source link

Refactor tools/eMMC/functions.sh #90

Closed siriobalmelli closed 5 years ago

siriobalmelli commented 5 years ago

Access /proc/cmdline only once. Refactor piped calls to (tr, grep, sed, awk) to a single sed call. Add comment to highlight what is being searched. Increase legibility and bring under 80-char line length.

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

RobertCNelson commented 5 years ago

@siriobalmelli , yeah this script can be a little fragile, i'm hoping finish testing with my collection of 3.8.x/4.1.x (uses uuid), 4.4.x - 4.14.x images..

siriobalmelli commented 5 years ago

Thanks for reviewing :)

I hear you, and happy to upstream what changes I make as I progress on a project which uses this.

FYI testing on a BBB (4.14 + custom config) as I go - but if you would like to point me to a few images I'd be happy to test with a variety before submitting pull requests so there is more confidence.

siriobalmelli commented 5 years ago

temporarily closing - will do extensive testing (and possibly push tweaks) before reopening