search

RobertCsordas / MobilECG-II

Open source ECG holter
385 stars 56 forks source link

reserved identifier violation #1

Closed elfring closed 8 years ago

elfring commented 8 years ago

I would like to point out that identifiers like "_ECG_FILTERS_H" and "_PACKET_READER_HPP" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

RobertCsordas commented 8 years ago

Thank you for reporting the issue! Fixed it in our part of the code. We leave third party libraries unchanged for easy updating in the future.

elfring commented 8 years ago

Thanks for your improvement of affected include guards.

Do any more source code places need another look?

RobertCsordas commented 8 years ago

Feel free to look at the code and report it if there is an issue somewhere. You can also fork the code, fix the critical parts and create a pull request for it. Keep in mind however that there are lots of open source libs in the code: the whole STM32 folder in the firmware, Bluetopia, SCMRTOS, libeeprom, etc. We want to make the absolute minimum changes to these in order to be able to change or update them easily.

elfring commented 8 years ago

Would you like to report this issue also to the mentioned third party libraries if they are similarly affected?

How do you think about to avoid that this software depends on undefined behaviour?