search

RobertD502 / home-assistant-flair

Custom component for Home Assistant Core for Flair pucks, vents, rooms, structures, and minisplits
MIT License
87 stars 12 forks source link

Request to publish releases to flair.zip #57

Closed ptr727 closed 1 year ago

ptr727 commented 1 year ago

Hi, thank you again for you custom component.

May I please request you publish via releases and not via the main branch.
Publishing to a targeted release would allow my ansible deployments to pickup a flair.zip.
It would also you to change your hacs manifest to use releases.

Yes, I know there is a release, but it is an auto release and as such it does not get a permalink that auto translates latest to a static target filename.

E.g. consider the following that publish using the domain name:
hacs: https://github.com/hacs/integration/releases/latest/download/hacs.zip hass-vantage: https://github.com/loopj/hass-vantage/releases/latest/download/vantage.zip

Vs. needing pull from main branch without knowing that it is a release or not:
flair: https://github.com/RobertD502/home-assistant-flair/archive/refs/heads/main.zip

RobertD502 commented 1 year ago

No problem, I'll add it to the workflow.

ptr727 commented 1 year ago

Looks like the release has not been pushed yet?

https://github.com/RobertD502/home-assistant-flair/latest/download/flair.zip is 404?

RobertD502 commented 1 year ago

Correct. The workflow starts when a new release is created.

ptr727 commented 1 year ago

Ok, but do keep in mind you already updated hacs.json, so hacs will also be looking for the release, just like I did, and may fail unless the flair.zip is present.
Maybe manually run the action to push the same release version but to flair.zip?

RobertD502 commented 1 year ago

Just tested in HACS and it doesn't look for the zip yet since the changes aren't reflected until the next release.

I'll have to go edit the workflow to manually dispatch. Will report back.

RobertD502 commented 1 year ago

Only way was to publish a new release. 0.1.8.3 should have flair.zip.

ptr727 commented 1 year ago

Thank you, confirmed it is present, I deploy using Ansible and I can now use your release zip.