search

RobertD502 / home-assistant-petkit

Home Assistant integration for PetKit devices
MIT License
213 stars 32 forks source link

feat: add new wastebin presence sensor for PuraMax2 #93

Open Jezza34000 opened 2 weeks ago

Jezza34000 commented 2 weeks ago

The new litter box PuraMax2 has a wastebin presence sensor

Jezza34000 commented 1 week ago

Are PRs welcome on this repo? @RobertD502 I still have other areas for improvement and some bug fixes to open, but before continuing I would still like to know if they have a chance of being merged ? (same for my PR #91)

RobertD502 commented 1 week ago

Are PRs welcome on this repo? @RobertD502

I still have other areas for improvement and some bug fixes to open, but before continuing I would still like to know if they have a chance of being merged ? (same for my PR #91)

Yes, they are. However, that is not a blanket statement to say all PRs will be accepted - as the integration is meant to be a simple interface with the PetKit API, PRs that add complexity with features (especially edge cases) that a user may want and should be accomplished/are better suited for automations or templates will not be accepted.

If someone has "areas of improvement" (I'm assuming you're referring to feature requests) or bug fixes, it is better to open up issues on the repo (for bugs) or GitHub discussions (for feature requests) where a discussion can be had or sending me a message on discord. If an idea doesn't fit the vision of this project, with it being open source, the user is still within their rights to maintain a fork of their own to meet their needs.

Now, that is not to say that this PR is not welcome! Regarding this PR: 1) This looks to be a new device Pura Max 2, so it would have a new type code? 2) With new devices, I don't merge code until the device is fully supported (its features and controls are implemented/tested to be in working order) in the backend - in this case, I'd expect for the Pura Max 2 to be supported in petkitaio prior to reviewing any code on the Home Assistant side. If you want, fork the main branch of the petkitaio library, in the state that it is currently in, and add support for the Pura Max 2 / handling of any of the controls that may be different or additions to the ones already there. Then add support for the Pura Max 2 and its relevant entities on the Home Assistant side.

Since the PetKit devices list just keeps growing, I'm trying to avoid previous project experiences of PRs being made and then the user abandoning fixing issues when things go wrong. By dedicating time to fully supporting a device, a user is more likely to feel a sense of responsibility for the code they created and more likely to step up fixing issues that are related to what they created - I'd hate to have to be the asshole who removes a supported device because the individual who implemented doesn't care to maintain it. In this case, removing support would be the only option as I'm not keen on using the limited free time that I have to support a device I don't have/use.

Jezza34000 commented 1 week ago

Okay thank you for your response. I don't completely agree with your vision but I respect yours.