Footnotes don't work when embedded in a list

[michaelforrest]

This code (parsed with footnotes: true, of course):

* here is a footnote in a list[^1]

[^1]: my footnote from the list

Results in the following AST:

{"ul", [], [{"li", [], ["here is a footnote in a list[^1]"], %{}}], %{}}

It's swallowing the footnote content and not creating a link in the list item.

I thought I'd try to be helpful by starting a PR on this but not sure it's useful without a solution! It's gonna be regex hell isn't it...

[RobertDober]

Thank you for reporting this and sorry for the late reply.

I'll have a look at this asap

[RobertDober]

I struggle with the complicated task to make lists much more GFM compliant for a long time :blush: I will keep this open as it's definitely a bug but have no schedule for a fix. Sorry about that

[michaelforrest]

"High hanging fruit" lol.

It's fine, for now I'm just putting my footnotes outside my lists!

[RobertDober]

Unfortunately it is high hanging fruit for me and a warning to potential PR authors.

Nevertheless I will try to fix it, eventually, whenever that may be.

[michaelforrest]

No no, I just meant that I like the term "high hanging fruit" - I hadn't seen it before! :-)

Totally understand the usage!

[RobertDober]

Oh good, I was afraid you thought it was easy to fix; Glad you like the label

[michaelforrest]

Sorry about that! Thanks for the library, it's really useful. (basically powers all my content on this site: https://squares.tv)

[RobertDober]

No need to apologize you are right to see the world with a smile, sometimes written communication is brittle. Happy EarmarkParser serves you, sorry for the bad list support (that's why I am so defensive)

[michaelforrest]

Nice one! 👍👍

[RobertDober]

appreciated @michaelforrest