search

RobertFOConnor / react-native-number-ticker

A simple easy-to-use ticker component for animating ticker numbers.
29 stars 15 forks source link

Display problems #3

Open calypsow777 opened 5 years ago

calypsow777 commented 5 years ago

Hi, thanks for the module!

I've noticed two little problems :

  1. Screenshot from 2019-05-27 14-50-22

I've set { borderTopWidth: 1, backgroundColor: 'red' } to textStyle

The bottom of the previous number is still visible when the animation is finished which is annoying if you want to center it properly. On iOS you can even see a bit of the previous number, which I fixed by setting a marginTop: 2

  1. Screenshot from 2019-05-27 14-58-17

Same styles as above

With a period or a comma, it takes too much space and is not exactly aligned with the numbers

Thanks for reading :)

RobertFOConnor commented 5 years ago

Thanks for using the library and taking the time to report the issue. I'll take a look and let you know when a fix has been pushed. :)

Gp2mv3 commented 5 years ago

We have the same issue, can you work on that ? Or do you have info about it ?

RobertFOConnor commented 5 years ago

What version of the library are you using? The latest is 0.1.5