search

RobertFrydenlund / SpotifyPlugin

72 stars 6 forks source link

Implements MeasureType CoverPath #3

Closed tjhrulz closed 7 years ago

tjhrulz commented 7 years ago

CoverPath is an unused MeasureType in the master branch. In this branch it is implemented to be be a string output of the web address of the AlbumArt. It is updated on finish of the downloading of the album art. The intent is for users to be able to be able to use OnChange events on measures of this type and not have to worry about the update rate of the album art measure being too slow and the OnChange not firing or having to deal with it double firing.

tjhrulz commented 7 years ago

Just figured it may be a useful addition to be able to have a measure type that you can have an onChange on without extra worry, and being able to know the web path of the image I'm sure could be useful in other circumstances.

tjhrulz commented 7 years ago

New updates now includes a fix to the current spotify issue. The webclient for oauth needs to not have a origin and the csrf one does. This makes each of those tasks have their own webclient. I also by request reverted the spotify is not running log to debug once again.

RobertFrydenlund commented 7 years ago

Implemented CoverPath as suggested, and changed "spotify not running" to debug. The Spotify issue should also be corrected now.