RobertFrydenlund / SpotifyPlugin

72 stars 6 forks source link

Overload position and length value types #5

Closed tjhrulz closed 7 years ago

tjhrulz commented 7 years ago

They were implmented as their own thing originally, now they are just overloaded with the original values. Now in a number context it is just the number and in the string context it is the string. I also left the ms in for personal reasons, if you want to int cast it please make it optional.

tjhrulz commented 7 years ago

I also should note that while they were implemented they were not a valid measure type and thus would default to length.

p.s. Why is length the default measure type instead of something like state?