search

RobertGummesson / BuildTimeAnalyzer-for-Xcode

Build Time Analyzer for Swift
MIT License
4.3k stars 260 forks source link

Build times should be cumulative #26

Closed eaigner closed 8 years ago

eaigner commented 8 years ago

Sometimes files show up multiple times with different build times. I suppose this is because of target dependencies. It would be nice if identical lines would be grouped and their cumulative build time displayed.

RobertGummesson commented 8 years ago

Sometimes files show up multiple times with different build times. I suppose this is because of target dependencies.

The plugin displays build times for functions rather than files (see the Function column). That would be why you see the same file show up multiple times.

eaigner commented 8 years ago

No. It's the same function name AND same file name

RobertGummesson commented 8 years ago

Ah, that would be a bug. I haven't actually seen this for any of my projects. Let me see if I am able to reproduce this when I have a moment.

If you have the time and are able to build the plugin yourself, it would be interesting to see if that goes away if: return time.hashValue ^ text.hashValue is swapped to: return text.hashValue in CMRawMeasure.swift.

eaigner commented 8 years ago

Example screenshot

screen shot 2016-05-23 at 12 19 04

eaigner commented 8 years ago

Let me check

eaigner commented 8 years ago

By the way. Is there a reason the results are capped at 20?

RobertGummesson commented 8 years ago

I added it for performance reasons but never benchmarked it. It could likely be increased.

RobertGummesson commented 8 years ago

Thanks for this find and your commits. Have merged the branch to master...