search

RobertHeim / phpbb-ext-topictags

phpBB 3.3 extension, that adds the ability to tag topics with key words.
GNU General Public License v2.0
29 stars 19 forks source link

fix delete syntax so it works for mysql as well as postgres #41

Closed RobertHeim closed 9 years ago

RobertHeim commented 9 years ago

see https://github.com/RobertHeim/phpbb-ext-topictags/commit/5ece4ea02aa6f739fad741b5632e7ce503cdef3a#commitcomment-9093237

RobertHeim commented 9 years ago

see https://www.phpbb.com/community/viewtopic.php?f=461&t=2283896

RobertHeim commented 9 years ago

waiting for somone to test master branch with postgres. https://github.com/RobertHeim/phpbb-ext-topictags/pull/39

Foxcapades commented 9 years ago

Sorry about the late reply. I haven't been able to get a query error on the latest revision in postgres, so that part looks good.

I didn't realize originally that MySQL allowed multi-table DELETE statements as I am more familiar with PgSQL which only allows single table operations with DELETE and allows aliases on tables used in DELETE statements, so I apologize for my pull request (#39) being problematic.

RobertHeim commented 9 years ago

Thank you EllieFops!