RobertHeim / phpbb-ext-topictags

phpBB 3.3 extension, that adds the ability to tag topics with key words.
GNU General Public License v2.0
29 stars 20 forks source link

use request->variable instead of get_super_globals in acp_listener #71

Closed RobertHeim closed 9 years ago

RobertHeim commented 9 years ago
  $post = $this->request->get_super_global(\phpbb\request\request::POST);
  $prune = isset($post['rh_topictags_prune']) ? $post['rh_topictags_prune'] : 0;

As you only use rh_topictags_prune you don't need the whole array. You should use request->variable instead. This happens in other places in your code as well.