search

RobertHeim / phpbb-ext-topictags

phpBB 3.3 extension, that adds the ability to tag topics with key words.
GNU General Public License v2.0
29 stars 19 forks source link

Fixed Background, Display Tags in Search View #84

Open PhocaCz opened 8 years ago

PhocaCz commented 8 years ago

3 new commits: 1) Fixed problem with background image, see the description of this problem: https://www.phpbb.com/community/viewtopic.php?f=456&t=2263616&p=14479291#p14476431 Background problem

2) Displaying tags in search view (function):

3) Displaying tags in search view (template)

RobertHeim commented 8 years ago

Hi, thanks for collaborating!! Find some annotations above, could you please incorporate them?

PhocaCz commented 8 years ago

Hi,

1) wrappers - they are not needed but they can help when modifying output per CSS, see example Topic Tags there is need to style different views differently so this is why they have different class names

2) rh_topictags - if this will fix the problem with displaying, then yes, of course

3) search_modify_tpl_ary - yes, the function is in fact copied from viewforum_modify_topicrow. There is one other small issue: if ($this->config[prefixes::CONFIG.'_display_tags_in_viewforum'])

Maybe there should be new config value for search view, for now the viewforum config is used, so it is in fact not correct.

Please, take this pull request as inspiration, I am new to phpBB coding, so for example, I am not able to do config parameter for the displaying in search view, etc. If you like the changes and you have idea how to implement the changes better way, please use your way.

Thank you.

jlgager24 commented 7 years ago

Thanks so much for this! It fixed the problem!

theantnest commented 6 years ago

Has this extension been abandoned?

Galixte commented 6 years ago

@theantnest, One year without any update, I think so.