RobertHoueland / enchantments-plus

Minecraft fabric mod that adds new fun and useful enchantments
https://www.curseforge.com/minecraft/mc-mods/enchantments-plus-fabric
MIT License
3 stars 6 forks source link

[Suggestion] Changing Life Steal calculations #12

Closed DeadRote closed 8 months ago

DeadRote commented 10 months ago

Currently, Life Steal is functioning in a very bizarre way, where it's not reflecting the current Life Steal heal amount according to the weapon's damage. Instead, it's taking 50% of the entity's current health as a healing value, which is completely broken when we talk about Warden fights, Ender Dragon, and other bosses if we are starting to implement other custom mods into the mix.

Considering that reading the player's damage is problematic (according to https://github.com/RobertHoueland/enchantments-plus/issues/10#issuecomment-1742183511 ), I propose implementing the usage of Life Steal level into the formula and limiting the max amount of the heal according to it as well. Would be nice to have those values be reflected in the config files as well.

Example of what I had implemented on my public server to nerf current Life Steal:

user.heal(Math.min((targetHealth * level * 0.05f),(level*3.0f)));

In that case - it either heals the player by still substantial amount or by the maximum cap considering the Life Steal level (when targetHealth is too big).

RobertHoueland commented 8 months ago

Thank you for the suggestion! I'll be implementing a change like you mentioned in the next update for life steal. As for config, I am waiting to change to a different config implementation to fix things like server side config, but have been a bit busy