RobertK66 / obc_1769_core

Implements hardware abstractions and Layer2(3) modules for usage of the OBC hardware in cubesat projects
GNU General Public License v3.0
1 stars 1 forks source link

Merge thruster features into develop branch #34

Closed kodsurf closed 1 year ago

kodsurf commented 1 year ago

Will initialize pull request.

Code compiled and runnable. Thruster requests features work the same as in my old branch (feature/thruster_controll).

Code still dirty : further commit would be to improve style and clean the code.

Please review/advice and lets discuss details ( needs for changes) inside pull request. Fixes would follow with commit reference.

RobertK66 commented 1 year ago

I just made commit https://github.com/RobertK66/obc_1769_core/pull/34/commits/c1f7512bea464726c193a5ec93afe598cd3d0a43 in order to get the project compiled again ;-). The language.settings.xml can be ignored/overwritten as long as only the hashes are changed locally. The .cproject file is important in this case!

@kodsurf: Before you make your next commit/sync from your local branch you have to make a fetch/pull from origin to get this change in sync again ;-).

RobertK66 commented 1 year ago

@kodsurf : are you available at skype. We could finalise this there with shared screen if you wish....

kodsurf commented 1 year ago

With latest commit I made thruster parser work as expected.

Parser is tested.

I now approve merge to dev