text hard to read with dark theme

RobertKrajewski / Sync-my-L2P

DOWNLOAD HERE: https://github.com/RobertKrajewski/Sync-my-L2P/releases/latest

http://www.syncmyl2p.de/

GNU Lesser General Public License v3.0

82 stars 27 forks source link

text hard to read with dark theme #114

Closed severoraz closed 5 years ago

severoraz commented 6 years ago

I am using a dark theme and I find some bits of text in the app hard to read, because they appear to be hardcoded-ly black, while other text does take on an automatic color.

Examples of text that shows black when using a dark theme:

element names in the Filebrowser tree view
entries in the Log view

Maybe there is some stylesheet somewhere or something equivalent which is forcing this texts to be black.

RobertKrajewski commented 6 years ago

Thanks for letting me know. The issue is this line: https://github.com/Sync-my-L2P/Sync-my-L2P/blob/0a3f64f74bd398cbc17f25b69f81dd1504c98f80/structureelement.cpp#L116

Depending on the synchronization state, a color is chosen for each element in the tree view. Currently all colors are hard-coded, but as I just found out, you can access the default color palette via http://doc.qt.io/qt-5/qapplication.html#palette-1 . I will try to integrate this into v2.3.0.

severoraz commented 6 years ago

Great, thanks for looking into it!

RobertKrajewski commented 5 years ago

fixed in f33c2aca2175757674d3a35c1253ba9099b72da6