search

RobertKrajewski / Sync-my-L2P

DOWNLOAD HERE: https://github.com/RobertKrajewski/Sync-my-L2P/releases/latest
http://www.syncmyl2p.de/
GNU Lesser General Public License v3.0
82 stars 27 forks source link

Handling of special characters in links and filepaths #135

Closed RobertKrajewski closed 5 years ago

RobertKrajewski commented 5 years ago

Currently, special characters like "+" or "ü" are not correctly handled in links in filepath. This causes unreadable directory and filenames, or even prevents the download at all.

Bergiu commented 5 years ago

I will make a pull request later to fix this. Some parts are fixed server side, for example the endcoding of titles and modulenames and they will be available with the next api release.

Bergiu commented 5 years ago

We will make an api release tomorrow or the day after tomorrow. then the bug with downloading files that contains + and the bug with other special characters that are displayed wrong will be fixed. the commit i have made will fix the special characters on subfolders, after the release.

Bergiu commented 5 years ago

The changes on the api is deployed, so it should work with this fix.

piet3 commented 5 years ago

Another Problem is that Moodle allows ":" in the names of topics. As it is not possible to create a folder with ":" in its name, Sync-my-L2P returns an error. It would be suffiecent, if Sync-my-L2P would just skip the Lehrveranstaltung and proceed. At the moment you can't use the program to download any files, if you have just a single Lehrveranstaltung that uses ":" in topics' name.

Bergiu commented 5 years ago

That depends on your filesystem. And I think it's already fixed with commit 6bdb9495012c647b32f02948d89b9f3398add686? What could also be a problem are module or topic names or filenames, that differ only in there caps.

Bergiu commented 5 years ago

image image

In Moodle you can even create modules with the same name... And these 4 modules are displayed in the same folder in sync my l2p.

But I would say that this is a different issue.

piet3 commented 5 years ago

Ah okay, and is there even no problem if you change the topic to something like: "Part 1: General"?

t-schroeder commented 5 years ago

Seems like the issue with ":" only affects Windows. On Mac e.g. the ":" is replaced by a "/".

@piet3 Instead of skipping the entire Lehrveranstaltung when a topic with ":" in its name is encountered, why not replace it with another character instead? Otherwise Sync-my-L2P would only sync some Lehrveranstaltungen and the user might not even notice that some are being skipped.

t-schroeder commented 5 years ago

Nevermind. I didn't realize this is already fixed.

LdwgWffnschmdt commented 5 years ago

Could you please release a new version with the ":" fix? It really makes the App unusable if you have one course with a colon in its name.