search

RobertMyles / tidyRSS

An R package for extracting 'tidy' data frames from RSS, Atom and JSON feeds
https://robertmyles.github.io/tidyRSS/
Other
82 stars 20 forks source link

Feed handling, why RCurl dep and github install link #1

Closed hrbrmstr closed 7 years ago

hrbrmstr commented 7 years ago

Congrats on the CRAN submission!

However…

Neither of these worked (the first 2 things I tried):

tidyfeed("https://rud.is/b/feed/")

tidyfeed("https://rweekly.org/atom.xml")

Those are totally valid feed that work in every RSS reader but not in your pkg.

xml2 already Suggests curl and httr and most folks who are likely to use this pkg have the tidyverse installed. RCurl adds a somewhat needless dep onto systems.

And:

devtools::install_github("https://github.com/RobertMyles/tidyrss")

should be

devtools::install_github("RobertMyles/tidyrss")
RobertMyles commented 7 years ago

Thanks @hrbrmstr. I was actually using curl and httr and I had the package ready, until I discovered it didn't work with some rss feeds, so I switched to RCurl, which did work with them. Thanks for the report, I'll get it fixed asap.