Closed alastairrushworth closed 4 years ago
Hi Alastair, thanks for reporting this. I thought I'd made the package a bit more bug-proof, but obviously not. And this feed had some surprises for me.
Anyway, there is a fix now in the 'namespace' branch (remotes::install_github("robertmyles/tidyrss@namespace")
). The problem was the xpath used to find the entries, and this could potentially be a problem for other feeds, so I appreciate the other issue you opened linking to those feeds as I can use those for testing.
I'll play with this a bit more over the next week and merge it into the master branch asap. Here's how it looks now:
> tidyfeed("http://bigcomputing.blogspot.com/feeds/posts/default")
GET request successful. Parsing...
# A tibble: 25 x 15
feed_title feed_url feed_last_updated feed_author feed_link feed_category feed_generator
<chr> <chr> <dttm> <chr> <chr> <list> <chr>
1 Big Compu… tag:blo… 2020-03-14 03:08:05 nphardhttp… http://b… <chr [1]> Blogger
2 Big Compu… tag:blo… 2020-03-14 03:08:05 nphardhttp… http://b… <chr [1]> Blogger
3 Big Compu… tag:blo… 2020-03-14 03:08:05 nphardhttp… http://b… <chr [1]> Blogger
4 Big Compu… tag:blo… 2020-03-14 03:08:05 nphardhttp… http://b… <chr [1]> Blogger
5 Big Compu… tag:blo… 2020-03-14 03:08:05 nphardhttp… http://b… <chr [1]> Blogger
6 Big Compu… tag:blo… 2020-03-14 03:08:05 nphardhttp… http://b… <chr [1]> Blogger
7 Big Compu… tag:blo… 2020-03-14 03:08:05 nphardhttp… http://b… <chr [1]> Blogger
8 Big Compu… tag:blo… 2020-03-14 03:08:05 nphardhttp… http://b… <chr [1]> Blogger
9 Big Compu… tag:blo… 2020-03-14 03:08:05 nphardhttp… http://b… <chr [1]> Blogger
10 Big Compu… tag:blo… 2020-03-14 03:08:05 nphardhttp… http://b… <chr [1]> Blogger
# … with 15 more rows, and 8 more variables: entry_title <chr>, entry_url <chr>,
# entry_last_updated <dttm>, entry_author <chr>, entry_content <chr>, entry_link <chr>,
# entry_category <list>, entry_published <dttm>
Hi Rob!
The new version of
tidyRSS
is great :)I noticed that some feeds I have that parsed with a previous tidyRSS version were failing. I've attached a single example here. It seems to occur somewhere in the parsing of the feed into a tibble.
This using the most up-to-date version:
Using a slightly older version (I think this commit was in January):
Thanks,
Alastair