Fix tidyselect `where()`warning #50

RobertMyles / tidyRSS

An R package for extracting 'tidy' data frames from RSS, Atom and JSON feeds

https://robertmyles.github.io/tidyRSS/

Other

82 stars 20 forks source link

Fix tidyselect `where()`warning #50 #52

Closed grimbough closed 3 years ago

grimbough commented 3 years ago

This hopefully addresses the tidyselect where() warning in #50

Adds call to where()
Imports tidyselect (where() isn't actually exported, so maybe this isn't necessary?)
Adds unit test to check tidyRSS::clean_up() is silent

RobertMyles commented 3 years ago

Hi Mike,

Thanks for your PR. Like you say, I'm not sure whether we need to import tidyselect at all, the comments by Lionel suggest not. Better to stay on the safe side and import it, I suppose.

Anyway, thanks again :-)

grimbough commented 3 years ago

No problem. I find the package very useful, but seeing the warning in my log files was getting to me! Glad I could contribute, thanks for merging so quickly.