search

RobertMyles / tidyRSS

An R package for extracting 'tidy' data frames from RSS, Atom and JSON feeds
https://robertmyles.github.io/tidyRSS/
Other
82 stars 20 forks source link

Rlang issue #61

Closed exploringfinance closed 2 years ago

exploringfinance commented 2 years ago

I had to go back a version because I kept getting this error. Does not exist in 2.0.4


sa = tidyfeed('https://seekingalpha.com/author/schiffgold.xml')
GET request successful. Parsing...

Error in `.f()`:
! Predicate functions must return a single `TRUE` or `FALSE`, not a missing value
Run `rlang::last_error()` to see where the error occurred.
RobertMyles commented 2 years ago

Sorry to see this happened, @exploringfinance , the new version passed all my tests. I'll have a look at this and see if I can see what's happening.

lgnbhl commented 2 years ago

I got the same issue, which broke a function of my R package BFS which has tidyRSS::tidyfeed() as a dependency. 

tidyfeed("https://www.bfs.admin.ch/bfs/de/home/statistiken/kataloge-datenbanken/daten/_jcr_content/par/ws_catalog.rss.xml")
GET request successful. Parsing...

Error in `.f()`:
! Predicate functions must return a single `TRUE` or `FALSE`, not a missing value
Run `rlang::last_error()` to see where the error occurred.

Thanks again for your great package!

lgnbhl commented 2 years ago

It would be very appreciated if you could fix this bug, so my BFS R package (https://github.com/lgnbhl/BFS/) can work again.

RobertMyles commented 2 years ago

@lgnbhl if you'd like to roll back to version 2.0.4, that should work for you for now, I'll put in a fix for this asap.

lgnbhl commented 2 years ago

@RobertMyles Thank you for your quick answer and for working on a fix. Yes, using version 2.0.4 allows my functions to work again.