search

RobertSkalko / Mine-And-Slash-Rework

Mine and Slash Minecraft Mod
https://www.curseforge.com/minecraft/mc-mods/mine-and-slash-reloaded
18 stars 23 forks source link

Talent Tree Screen Rework #109

Open TUsama opened 2 months ago

TUsama commented 2 months ago

before: QQ_1722531723550

after: QQ_1722531537275

RobertSkalko commented 2 months ago

Ok i read a bit through it. Honestly is it possible to make this not a code refactor, but an addition? There's a few pieces of code like the render image parts that I'm pretty sure would have no way of knowing how to port to next minecraft version.

So just not touch any of my current code and add your talent tree in a new place that i'll use as long as it works and i know how to fix it. If it ever breaks, i can then go back to the old tree gui until you can PR a fix?

TUsama commented 2 months ago

Ok i read a bit through it. Honestly is it possible to make this not a code refactor, but an addition? There's a few pieces of code like the render image parts that I'm pretty sure would have no way of knowing how to port to next minecraft version.

So just not touch any of my current code and add your talent tree in a new place that i'll use as long as it works and i know how to fix it. If it ever breaks, i can then go back to the old tree gui until you can PR a fix?

I feel that way too, currently the code that triggered these new mechanics is scattered around, which is unhealthy for the project maintenance, I'll find a way to further modulize it.