RobertSkalko / Mine-And-Slash-Rework

attempt at rework+port
15 stars 22 forks source link

[Bug]: Huge lag spikes in adventure map dungeons #112

Open KaxelDreamhack123 opened 4 weeks ago

KaxelDreamhack123 commented 4 weeks ago

Describe the bug you're experiencing

After entering into dungeon via Map Device, my fps coming to 4+ fps with huge lag spikes, like a 4 fps to 100+ fps and again, slide show but not so hard, its making it not playable. Im playing on latest version forge 1.20.1

Reproducability

I have many perfomance mods, Embeddium latest version, embeddium++, immediately Fast, Noisium, Radium from Asek, Distant Horizons(im disabling it in dungeon), modernfix, connectivity and some not huge perfomance mods. I dont know, but maybe its happening because i need to turn on or off something?

Mod up to date

Tested Without Custom Mine and Slash Datapacks

Mine and Slash version

Forge 1.20.1 - 5.6.1

Logs

https://gist.github.com/KaxelDreamhack123/688f0f339e77141e99ee99cb36b76c55

RobertSkalko commented 4 weeks ago

Can you use spark to profile it? If it's fps lag, use client, if it's tick lag, use server profiler https://spark.lucko.me/

If you can start profiler before the lag happens, catch the lag and send me the spark log, i might have an idea what's causing the lag

KaxelDreamhack123 commented 3 weeks ago

Can you use spark to profile it? If it's fps lag, use client, if it's tick lag, use server profiler https://spark.lucko.me/

If you can start profiler before the lag happens, catch the lag and send me the spark log, i might have an idea what's causing the lag

Yes, its happening only on client, server not lagging, im also forgot to say, that im playing on server. This is a spark client: https://spark.lucko.me/lI55wzm6tW; Im ran it before entering into dungeon with 5 sec delay, and i was there in dungeon around 30 secs.

KaxelDreamhack123 commented 3 weeks ago

Can you use spark to profile it? If it's fps lag, use client, if it's tick lag, use server profiler https://spark.lucko.me/ If you can start profiler before the lag happens, catch the lag and send me the spark log, i might have an idea what's causing the lag

Yes, its happening only on client, server not lagging, im also forgot to say, that im playing on server. This is a spark client: https://spark.lucko.me/lI55wzm6tW; Im ran it before entering into dungeon with 5 sec delay, and i was there in dungeon around 30 secs.

Also, i forgot to say. My friends also exploring dungeons mine and slash mod, but one friend have a pc lower on spec that mine in 2x, but somehow entered into dungeon and not had any fps problem, only stable 60+ fps. I think some dungeons works pretty well. In one dungeon i have not so big lag spikes, like 30 to 100, but some dungeons getting my pc really hard to play xd

RobertSkalko commented 3 weeks ago

From a glance it's something with lava fluids and sounds..

KaxelDreamhack123 commented 3 weeks ago

Can you use spark to profile it? If it's fps lag, use client, if it's tick lag, use server profiler https://spark.lucko.me/ If you can start profiler before the lag happens, catch the lag and send me the spark log, i might have an idea what's causing the lag

Yes, its happening only on client, server not lagging, im also forgot to say, that im playing on server. This is a spark client: https://spark.lucko.me/lI55wzm6tW; Im ran it before entering into dungeon with 5 sec delay, and i was there in dungeon around 30 secs.

Also, i forgot to say. My friends also exploring dungeons mine and slash mod, but one friend have a pc lower on spec that mine in 2x, but somehow entered into dungeon and not had any fps problem, only stable 60+ fps. I think some dungeons works pretty well. In one dungeon i have not so big lag spikes, like 30 to 100, but some dungeons getting my pc really hard to play xd

My log also looks not crazy in saying some. I entered into dungeon, was there around 1 min, quit, looked into log and log saying usual stuff, not some crashes, some not usual.

KaxelDreamhack123 commented 3 weeks ago

Can you use spark to profile it? If it's fps lag, use client, if it's tick lag, use server profiler https://spark.lucko.me/ If you can start profiler before the lag happens, catch the lag and send me the spark log, i might have an idea what's causing the lag

Yes, its happening only on client, server not lagging, im also forgot to say, that im playing on server. This is a spark client: https://spark.lucko.me/lI55wzm6tW; Im ran it before entering into dungeon with 5 sec delay, and i was there in dungeon around 30 secs.

Also, i forgot to say. My friends also exploring dungeons mine and slash mod, but one friend have a pc lower on spec that mine in 2x, but somehow entered into dungeon and not had any fps problem, only stable 60+ fps. I think some dungeons works pretty well. In one dungeon i have not so big lag spikes, like 30 to 100, but some dungeons getting my pc really hard to play xd

My log also looks not crazy in saying some. I entered into dungeon, was there around 1 min, quit, looked into log and log saying usual stuff, not some crashes, some not usual.

Just dropped fps from stable 120 in lock mode fps to 5+ fps lag spikes xd

KaxelDreamhack123 commented 3 weeks ago

There is it log chunk: [18:17:40] [DH-Parent Update Queue [overworld] Thread[0]/INFO]: Update thread [DH-Parent Update Queue [overworld] Thread[0]] terminated. [18:17:40] [Render thread/INFO]: Reloading pipeline on dimension change: NamespacedId{namespace='minecraft', name='overworld'} => NamespacedId{namespace='mmorpg', name='dungeon'} [18:17:40] [Render thread/INFO]: Destroying pipeline NamespacedId{namespace='minecraft', name='overworld'} [18:17:40] [Render thread/INFO]: Creating pipeline for dimension NamespacedId{namespace='mmorpg', name='dungeon'} [18:17:40] [Render thread/INFO]: Stopping worker threads [18:17:40] [Render thread/INFO]: Started 3 worker threads [18:17:40] [Render thread/INFO]: Stopping worker threads [18:17:40] [Render thread/INFO]: Started 3 worker threads [18:17:40] [Render thread/INFO]: Stopping worker threads [18:17:40] [Render thread/INFO]: Started 3 worker threads [18:17:40] [Render thread/INFO]: [CHAT] Teleported kaxeoleg to 1616344.500000, 57.000000, 964024.500000 [18:17:40] [Render thread/INFO]: Setting up renderer [18:17:40] [Render thread/INFO]: Loading shader with type: 35633 [18:17:40] [Render thread/INFO]: Shader loaded sucessfully. [18:17:40] [Render thread/INFO]: Loading shader with type: 35632 [18:17:40] [Render thread/INFO]: Shader loaded sucessfully. [18:17:40] [Render thread/INFO]: Vertex Attribute (GL43+) completed. It contains 1 binding points and a stride size of 16 [18:17:40] [Render thread/INFO]: Quad IBO Resizing from [0] to [16384] with type: GL_UNKNOWN(5125) [18:17:40] [Render thread/INFO]: Renderer setup complete [18:17:40] [Render thread/INFO]: Renderer Cleanup Started [18:17:40] [Render thread/INFO]: Renderer Cleanup Complete [18:17:42] [Render thread/INFO]: [CHAT] Teleported to the [The Bastion] Dungeon [18:18:03] [Render thread/INFO]: level load [18:18:03] [Render thread/INFO]: Loading client level [Wrapped{ClientLevel@overworld}]-[overworld]. [18:18:03] [Render thread/INFO]: Default Sub Dimension not found. Creating: [overworld] [18:18:03] [DH-Full Data Migration Thread: [overworld] Thread[0]/INFO]: Attempting to migrate data sources for: [overworld]-[C:\Users\Bupyc\AppData\Roaming.minecraft\Distant_Horizons_server_data\Minecraft+Server\overworld]... [18:18:03] [DH-Full Data Migration Thread: [overworld] Thread[0]/INFO]: Found [0] data sources that need migration. [18:18:03] [DH-Full Data Migration Thread: [overworld] Thread[0]/INFO]: No migration necessary. [18:18:03] [Render thread/INFO]: Started DHLevel for Wrapped{ClientLevel@overworld} with saves at [ClientOnlySaveStructure@Minecraft+Server] [18:18:03] [Render thread/INFO]: Loaded [0] waiting chunk wrappers. [18:18:03] [Render thread/INFO]: level unload [18:18:03] [Render thread/INFO]: Unloading client level [Wrapped{ClientLevel@overworld}]-[overworld]. [18:18:03] [Render thread/INFO]: Unloading level com.seibel.distanthorizons.core.level.DhClientLevel@16f293fb [18:18:03] [Render thread/INFO]: Shutting down ClientRenderState [18:18:03] [Render thread/INFO]: Shutting down LodRenderer... [18:18:03] [Render thread/INFO]: Queuing Renderer Cleanup for main render thread [18:18:03] [Render thread/INFO]: Finished shutting down LodRenderer [18:18:03] [Render thread/INFO]: Shutting down LodQuadTree... [18:18:03] [Render thread/INFO]: Finished shutting down LodQuadTree [18:18:04] [Render thread/INFO]: Closing [RemoteFullDataSourceProvider] for level: [com.seibel.distanthorizons.core.level.DhClientLevel@16f293fb]. [18:18:04] [Render thread/INFO]: Closing [FullDataSourceProviderV1] for level: [com.seibel.distanthorizons.core.level.DhClientLevel@16f293fb]. [18:18:04] [Render thread/INFO]: Closed DhClientLevel for Wrapped{ClientLevel@overworld} [18:18:04] [DH-Parent Update Queue [overworld] Thread[0]/INFO]: Update thread [DH-Parent Update Queue [overworld] Thread[0]] terminated. [18:18:04] [Render thread/INFO]: Reloading pipeline on dimension change: NamespacedId{namespace='mmorpg', name='dungeon'} => NamespacedId{namespace='minecraft', name='overworld'} [18:18:04] [Render thread/INFO]: Destroying pipeline NamespacedId{namespace='mmorpg', name='dungeon'} [18:18:04] [Render thread/INFO]: Creating pipeline for dimension NamespacedId{namespace='minecraft', name='overworld'} [18:18:04] [Render thread/INFO]: Stopping worker threads [18:18:04] [Render thread/INFO]: Started 3 worker threads [18:18:04] [Render thread/INFO]: Stopping worker threads [18:18:04] [Render thread/INFO]: Started 3 worker threads [18:18:04] [Render thread/INFO]: Stopping worker threads [18:18:04] [Render thread/INFO]: Started 3 worker threads [18:18:04] [Render thread/INFO]: [CHAT] Teleported kaxeoleg to 2660.500000, 90.000000, -1799.500000 [18:18:04] [Render thread/WARN]: Received passengers for unknown entity [18:18:06] [Render thread/INFO]: Setting up renderer [18:18:06] [Render thread/INFO]: Loading shader with type: 35633 [18:18:06] [Render thread/INFO]: Shader loaded sucessfully. [18:18:06] [Render thread/INFO]: Loading shader with type: 35632 [18:18:06] [Render thread/INFO]: Shader loaded sucessfully. [18:18:06] [Render thread/INFO]: Vertex Attribute (GL43+) completed. It contains 1 binding points and a stride size of 16 [18:18:06] [Render thread/INFO]: Quad IBO Resizing from [0] to [16384] with type: GL_UNKNOWN(5125) [18:18:06] [Render thread/INFO]: Renderer setup complete [18:18:06] [Render thread/INFO]: Renderer Cleanup Started [18:18:06] [Render thread/INFO]: Renderer Cleanup Complete

KaxelDreamhack123 commented 3 weeks ago

From a glance it's something with lava fluids and sounds..

Well, idk what it means in dev xd

KaxelDreamhack123 commented 3 weeks ago

Also, i played many dimensions, ad astra as example with DH, Undergarden, many others, never seen this.

KaxelDreamhack123 commented 3 weeks ago

I really want to explore them but mobs not have fps issue than me, so, im dying xd

RobertSkalko commented 3 weeks ago

I'm going to send you a jar in which I disable sound for the first 5 seconds after joining a map. Please report if the bug is gone.

KaxelDreamhack123 commented 3 weeks ago

I'm going to send you a jar in which I disable sound for the first 5 seconds after joining a map. Please report if the bug is gone.

Okay, i think my pc will not corrupt after that, im joking.

RobertSkalko commented 3 weeks ago

https://file.io/5wCETSlBeVyS

No sound for 5s after joining a map here

KaxelDreamhack123 commented 3 weeks ago

https://file.io/5wCETSlBeVyS

No sound for 5s after joining a map here

Haha, yes. I entered a dungeon and now a stable 120 fps without any lag spikes.

KaxelDreamhack123 commented 3 weeks ago

Also, exploring dungeon now not have any problems with fps, just stable 120 fps.

RobertSkalko commented 3 weeks ago

I might have to try find out what causes so much sound lag when teleporting into dungeons, maybe it's when map generation happens but idk what lava has to do with it.. Something just spams the sound engine with so many sounds it just clogs up the game for a minute until all the sounds are done

Can you come to discord? I'm thinking of maybe trying to figure out whats actually happening or making a better solution than 5s of no sound on dungeon teleports

KaxelDreamhack123 commented 3 weeks ago

I might have to try find out what causes so much sound lag when teleporting into dungeons, maybe it's when map generation happens but idk what lava has to do with it.. Something just spams the sound engine with so many sounds it just clogs up the game for a minute until all the sounds are done

Can you come to discord? I'm thinking of maybe trying to figure out whats actually happening or making a better solution than 5s of no sound on dungeon teleports

Maybe also its because im playing with mods Extreme Sound Muffler and Sound Physics Remastered, i dont know. I can come to discord, but cant speak.

RobertSkalko commented 3 weeks ago

Oh nah i didn't invite you for a voice chat or anything, just so i can grab you with an @ in case i have ideas to test the lag source

KaxelDreamhack123 commented 3 weeks ago

Oh nah i didn't invite you for a voice chat or anything, just so i can grab you with an @ in case i have ideas to test the lag source

Okay