[Bug]: buff continue to stack

Oscar0159 commented 6 hours ago

Describe the bug you're experiencing

I upgraded my version from 1.20.1-v5.6.5 to 1.20.1-v5.7.3 and discovered this bug. I have not tested versions v5.7.0 to v5.7.2.

When a player swaps hands with an item (not an empty item) or runs, the buffs continue to stack, causing the magic shield, damage, resistance, etc., to reach very high values or their maximum limits.

Reproducability

Quickly switch the player’s hand item using the scroll wheel or hotkeys.

Mod up to date

[X] Before submitting this issue I updated to the newest version and reproduced it

Tested Without Custom Mine and Slash Datapacks

[X] In case I used Mine and Slash datapacks, I ran Mine and Slash in a new instance without custom datapacks and confirmed the bug still exists

Mine and Slash version

1.20.1-v5.7.3

Logs

https://gist.github.com/Oscar0159/303baf017cfba68773b3f128d3a31c77

RobertSkalko commented 6 hours ago

Hm i can't reproduce this one right now, are you on the mine and slash discord?

Oscar0159 commented 6 hours ago

yes

RobertSkalko commented 6 hours ago

I'll drop a jar in #general , try if the bug still happens

RobertSkalko commented 5 hours ago

Well found the reason, should be fixed next update https://github.com/RobertSkalko/Mine-And-Slash-Rework/commit/ad31a611ac7cbf2d1b95f939d5fa1778d45223d8

The old system always produced new statcontexts on every gear calculation, so editing them was fine. New system caches them.. so editing is not good

RobertSkalko / Mine-And-Slash-Rework